Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix permission check on api create org #5523

Merged
merged 2 commits into from
Dec 11, 2018
Merged

fix permission check on api create org #5523

merged 2 commits into from
Dec 11, 2018

Conversation

lunny
Copy link
Member

@lunny lunny commented Dec 11, 2018

No description provided.

@lunny lunny mentioned this pull request Dec 11, 2018
Merged
@codecov-io
Copy link

codecov-io commented Dec 11, 2018 •
edited
Loading

Codecov Report

Merging #5523 into master will decrease coverage by 0.04%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5523      +/-   ##
==========================================
- Coverage   37.62%   37.57%   -0.05%     
==========================================
  Files         319      319              
  Lines       46947    46947              
==========================================
- Hits        17662    17640      -22     
- Misses      26775    26797      +22     
  Partials     2510     2510
Impacted Files Coverage Δ
routers/api/v1/org/org.go 48.85% <0%> (ø) ⬆️
models/unit.go 0% <0%> (-14.29%) ⬇️
modules/indexer/repo.go 64.28% <0%> (-5.56%) ⬇️
models/repo_indexer.go 44.49% <0%> (-5.51%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba75319...da88a68. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 11, 2018
@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 11, 2018
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 11, 2018
@techknowlogick techknowlogick merged commit 58c4559 into go-gitea:master Dec 11, 2018
@lafriks lafriks added this to the 1.7.0 milestone Dec 11, 2018
@lunny lunny deleted the lunny/fix_create_org_permission_check branch December 12, 2018 00:54
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@Bwko Bwko Bwko approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@lunny @codecov-io @techknowlogick @Bwko @lafriks @bkcsoft