Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix forgot deletion of notification when delete repository #5506

Merged
merged 2 commits into from
Dec 10, 2018
Merged

fix forgot deletion of notification when delete repository #5506

merged 2 commits into from
Dec 10, 2018

Conversation

lunny
Copy link
Member

@lunny lunny commented Dec 9, 2018

will fix #3105

@lunny lunny added this to the 1.7.0 milestone Dec 9, 2018
@codecov-io
Copy link

codecov-io commented Dec 9, 2018 •
edited

Codecov Report

Merging #5506 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5506      +/-   ##
==========================================
- Coverage   37.64%   37.63%   -0.01%     
==========================================
  Files         317      317              
  Lines       46827    46828       +1     
==========================================
  Hits        17626    17626              
- Misses      26700    26701       +1     
  Partials     2501     2501
Impacted Files Coverage Δ
models/repo.go 42.78% <0%> (-0.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 928417a...7dfd013. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 9, 2018
@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 9, 2018
@lafriks
Copy link
Member

lafriks commented Dec 9, 2018

Don't we need migration for this?

@lunny
Copy link
Member Author

lunny commented Dec 10, 2018 •
edited

@lafriks I will send another PR to v1.7 but not back port to migrate because we cannot add migration on v1.6. When user upgrade from v1.6 to v1.7, the migration will be triggered.

@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 10, 2018
@lafriks lafriks merged commit 1b3404e into go-gitea:master Dec 10, 2018
lunny added a commit to lunny/gitea that referenced this pull request Dec 11, 2018
@lunny
fix forgot deletion of notification when delete repository (go-gitea#…
4d1b8db 
…5506)
@lunny lunny mentioned this pull request Dec 11, 2018
Merged
@lunny lunny added the backport/done All backports for this PR have been created label Dec 11, 2018
@lunny lunny deleted the lunny/del_notification_when_del_repo branch December 11, 2018 01:25
lunny added a commit that referenced this pull request Dec 11, 2018
@lunny
fix forgot deletion of notification when delete repository (#5506) (#…
60d7b61 
…5514)
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@adelowo adelowo adelowo approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.

Notifications remains after repository or issue deleted.
5 participants
@lunny @codecov-io @lafriks @adelowo @bkcsoft