Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix empty wiki #5504

Merged
merged 3 commits into from
Dec 9, 2018
Merged

Fix empty wiki #5504

merged 3 commits into from
Dec 9, 2018

Conversation

lunny
Copy link
Member

@lunny lunny commented Dec 9, 2018

When git push an empty wiki repo, the wiki page will be 500. This PR fix that issue.

@lunny lunny added this to the 1.7.0 milestone Dec 9, 2018
@codecov-io
Copy link

codecov-io commented Dec 9, 2018 •
edited

Codecov Report

Merging #5504 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5504      +/-   ##
==========================================
- Coverage   37.63%   37.62%   -0.02%     
==========================================
  Files         317      317              
  Lines       46826    46827       +1     
==========================================
- Hits        17623    17618       -5     
- Misses      26701    26709       +8     
+ Partials     2502     2500       -2
Impacted Files Coverage Δ
routers/repo/wiki.go 45.18% <0%> (-0.16%) ⬇️
models/unit.go 0% <0%> (-14.29%) ⬇️
models/repo_list.go 63.29% <0%> (-1.27%) ⬇️
routers/repo/view.go 44.78% <0%> (-1.23%) ⬇️
modules/process/manager.go 81.15% <0%> (+4.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e5abe2...9b6b614. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 9, 2018
@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 9, 2018
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 9, 2018
@techknowlogick techknowlogick merged commit 928417a into go-gitea:master Dec 9, 2018
@techknowlogick
Copy link
Member

@lunny backport please 😄

@lunny lunny deleted the lunny/fix_empty_wiki branch December 10, 2018 00:52
lunny added a commit to lunny/gitea that referenced this pull request Dec 10, 2018
@lunny
Fix empty wiki (go-gitea#5504)
00a692a 
* fix wiki page when wiki path is exist but empty

* improve the error check
@lunny lunny mentioned this pull request Dec 10, 2018
Merged
@lunny lunny added the backport/done All backports for this PR have been created label Dec 10, 2018
lafriks pushed a commit that referenced this pull request Dec 10, 2018
@lunny @lafriks
Fix empty wiki (#5504) (#5508)
2b4f87d 
* fix wiki page when wiki path is exist but empty

* improve the error check
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@lafriks lafriks lafriks approved these changes

@Bwko Bwko Bwko approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@lunny @codecov-io @techknowlogick @lafriks @Bwko @bkcsoft