Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix clone wiki failed via ssh #5503

Merged
merged 6 commits into from
Dec 11, 2018
Merged

fix clone wiki failed via ssh #5503

merged 6 commits into from
Dec 11, 2018

Conversation

lunny
Copy link
Member

@lunny lunny commented Dec 9, 2018

will fix #5291

@lunny lunny added this to the 1.7.0 milestone Dec 9, 2018
@codecov-io
Copy link

codecov-io commented Dec 9, 2018 •
edited

Codecov Report

Merging #5503 into master will increase coverage by 0.02%.
The diff coverage is 5.26%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5503      +/-   ##
==========================================
+ Coverage   37.59%   37.62%   +0.02%     
==========================================
  Files         318      319       +1     
  Lines       46928    46947      +19     
==========================================
+ Hits        17643    17662      +19     
- Misses      26774    26775       +1     
+ Partials     2511     2510       -1
Impacted Files Coverage Δ
routers/private/wiki.go 0% <0%> (ø)
routers/private/internal.go 55.73% <100%> (+0.73%) ⬆️
models/repo_list.go 63.29% <0%> (-1.27%) ⬇️
models/repo_indexer.go 50% <0%> (+5.5%) ⬆️
modules/indexer/repo.go 69.84% <0%> (+5.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccea916...383a7f3. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 9, 2018
@lafriks
Copy link
Member

lafriks commented Dec 9, 2018

Does user need code rights for wiki?

lunny
lunny commented Dec 10, 2018
View reviewed changes
cmd/serv.go
isWiki bool
unitType = models.UnitTypeCode
unitName = "code"
)
if strings.HasSuffix(reponame, ".wiki") {
isWiki = true
unitType = models.UnitTypeWiki
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lafriks, no, this line give the unitType as UnitTypeWiki.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, you are right

@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 11, 2018
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 11, 2018
@techknowlogick techknowlogick merged commit ba75319 into go-gitea:master Dec 11, 2018
@lunny lunny deleted the lunny/fix_ssh_clone_wiki branch December 12, 2018 00:52
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@appleboy appleboy appleboy approved these changes

@lafriks lafriks lafriks approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.

Can't clone wiki
6 participants
@lunny @codecov-io @lafriks @appleboy @techknowlogick @bkcsoft