Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tests for api user orgs #5494

Merged
merged 3 commits into from
Dec 9, 2018
Merged

Conversation

lunny
Copy link
Member

@lunny lunny commented Dec 8, 2018

Add tests for confirm #5485 and also allow site admin list user's orgs via API even if he is hidden himself on that org.

@codecov-io
Copy link

codecov-io commented Dec 8, 2018

Codecov Report

Merging #5494 into master will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5494      +/-   ##
==========================================
+ Coverage   37.57%   37.63%   +0.06%     
==========================================
  Files         317      317              
  Lines       46824    46824              
==========================================
+ Hits        17593    17623      +30     
+ Misses      26732    26699      -33     
- Partials     2499     2502       +3
Impacted Files Coverage Δ
routers/api/v1/org/org.go 48.85% <100%> (+25.19%) ⬆️
modules/process/manager.go 76.81% <0%> (-4.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b4453c...2837235. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 8, 2018
@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 8, 2018
@lunny lunny added this to the 1.7.0 milestone Dec 8, 2018
@lunny lunny added the type/enhancement An improvement of existing functionality label Dec 8, 2018
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 8, 2018
@lunny lunny merged commit da5a0b8 into go-gitea:master Dec 9, 2018
@lunny lunny deleted the lunny/api_add_test_orgs branch December 9, 2018 02:19
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality type/testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants