fix topic name length on database #5493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
techknowlogick
approved these changes
Dec 8, 2018
bkcsoft
added
the
lgtm/need 1
Codecov Report
@@ Coverage Diff @@
## master #5493 +/- ##
==========================================
- Coverage 37.56% 37.56% -0.01%
==========================================
Files 317 317
Lines 46824 46824
==========================================
- Hits 17591 17589 -2
- Misses 26734 26737 +3
+ Partials 2499 2498 -1
Continue to review full report at Codecov.
|
Bwko
approved these changes
Dec 8, 2018
bkcsoft
added
lgtm/done
lafriks
approved these changes
Dec 8, 2018
|
Please send backport |
lunny
added a commit
that referenced
this pull request
Dec 8, 2018
lafriks
pushed a commit
that referenced
this pull request
Dec 9, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we have controlled topic name length is less than 25, so we should change the name column's length.This will fix #5491