Improve team members and repositories settings UI #5457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5457 +/- ##
==========================================
+ Coverage 37.63% 37.64% +<.01%
==========================================
Files 317 317
Lines 46824 46826 +2
==========================================
+ Hits 17623 17626 +3
Misses 26699 26699
+ Partials 2502 2501 -1
Continue to review full report at Codecov.
|
bkcsoft
added
the
lgtm/need 2
lafriks
added
type/enhancement
lunny
force-pushed
the
lunny/improve_team_ui
branch
from
285bda3
to
9a8b9ee
Compare
lunny
changed the title
|
It's ready to review. @go-gitea/maintainers |
lafriks
requested changes
Dec 9, 2018
options/locale/locale_en-US.ini
Outdated
| @@ -1327,6 +1327,8 @@ teams.add_team_repository = Add Team Repository | |||
| teams.remove_repo = Remove | |||
| teams.add_nonexistent_repo = "The repository you're trying to add does not exist; please create it first." | |||
| teams.add_duplicate_users = User is already a team member. | |||
| teams.repos.none = No repository could be accessed by this team members. | |||
There was a problem hiding this comment.
Should be No repositories can be accessed by this team.
options/locale/locale_en-US.ini
Outdated
| @@ -1327,6 +1327,8 @@ teams.add_team_repository = Add Team Repository | |||
| teams.remove_repo = Remove | |||
| teams.add_nonexistent_repo = "The repository you're trying to add does not exist; please create it first." | |||
| teams.add_duplicate_users = User is already a team member. | |||
| teams.repos.none = No repository could be accessed by this team members. | |||
| teams.members.none = No member on this team. | |||
There was a problem hiding this comment.
Should be No members in this team.
lunny
force-pushed
the
lunny/improve_team_ui
branch
from
ca204c6
to
945b3ca
Compare
|
@lafriks done. |
|
LGTM |
bkcsoft
added
lgtm/need 1
lafriks
approved these changes
Dec 9, 2018
bkcsoft
added
lgtm/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The team settings UI is something confusing and this PR will refactor that UI. It removed the links and add tab to switch team members and team repositories. It should fix #2691. See below screenshots.