Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade alpine to 3.8 #5423

Merged
merged 4 commits into from
Nov 29, 2018
Merged

Upgrade alpine to 3.8 #5423

merged 4 commits into from
Nov 29, 2018

Conversation

techknowlogick
Copy link
Member

As title

@techknowlogick techknowlogick added this to the 1.7.0 milestone Nov 28, 2018
@bkcsoft bkcsoft added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Nov 28, 2018
@gaydin
Copy link

gaydin commented Nov 28, 2018

Is it possible to upgrade to 3.8 too?

gitea/Dockerfile

Line 4 in 268bbc9

FROM golang:1.11-alpine3.7 AS build-env

@techknowlogick
Copy link
Member Author

@gaydin yup. Thank you for the suggestion. I've updated.

@codecov-io
Copy link

codecov-io commented Nov 28, 2018 •
edited
Loading

Codecov Report

Merging #5423 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5423      +/-   ##
==========================================
- Coverage   37.55%   37.54%   -0.01%     
==========================================
  Files         317      317              
  Lines       46832    46832              
==========================================
- Hits        17588    17585       -3     
- Misses      26744    26746       +2     
- Partials     2500     2501       +1
Impacted Files Coverage Δ
modules/process/manager.go 76.81% <0%> (-4.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2dc805c...7271bff. Read the comment docs.

@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 29, 2018
@techknowlogick techknowlogick merged commit 5c13ba8 into go-gitea:master Nov 29, 2018
@techknowlogick techknowlogick deleted the techknowlogick-patch-9 branch November 29, 2018 02:33
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/deployment
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.
6 participants
@techknowlogick @gaydin @codecov-io @lunny @lafriks @bkcsoft