Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix heatmap colors for Chrome/Safari #5421

Merged
merged 3 commits into from
Nov 28, 2018
Merged

Fix heatmap colors for Chrome/Safari #5421

merged 3 commits into from
Nov 28, 2018

Conversation

lafriks
Copy link
Member

@lafriks lafriks commented Nov 27, 2018 •
edited
Loading

Workaround Chrome/Safari bug

Fixes #5420

@lafriks lafriks added this to the 1.7.0 milestone Nov 27, 2018
@codecov-io
Copy link

codecov-io commented Nov 27, 2018 •
edited
Loading

Codecov Report

Merging #5421 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5421   +/-   ##
=======================================
  Coverage   37.61%   37.61%           
=======================================
  Files         315      315           
  Lines       46714    46714           
=======================================
  Hits        17572    17572           
- Misses      26649    26650    +1     
+ Partials     2493     2492    -1
Impacted Files Coverage Δ
models/repo_indexer.go 48.3% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eabbddc...3932908. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 27, 2018
@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 28, 2018
@lunny
Copy link
Member

lunny commented Nov 28, 2018

Should also fix #5191

@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 28, 2018
@lafriks lafriks merged commit f17524b into go-gitea:master Nov 28, 2018
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@BetaCat0 BetaCat0 BetaCat0 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.

Heatmap renders black squares now
5 participants
@lafriks @codecov-io @lunny @BetaCat0 @bkcsoft