Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix password variable shadowing #5405

Merged
merged 1 commit into from
Nov 26, 2018

Conversation

adelowo
Copy link
Member

@adelowo adelowo commented Nov 26, 2018

My bad. While the password is randomly generated, it doesn't actually get stored in
the original password variable as it is declared in a new scope with :=.

So an empty string will always be the password anytime -random-password-length is used

@bkcsoft bkcsoft added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Nov 26, 2018
@lunny lunny added the type/bug label Nov 26, 2018
@lunny lunny added this to the 1.7.0 milestone Nov 26, 2018
@codecov-io
Copy link

Codecov Report

Merging #5405 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5405      +/-   ##
==========================================
- Coverage   37.45%   37.45%   -0.01%     
==========================================
  Files         312      312              
  Lines       46510    46510              
==========================================
- Hits        17422    17420       -2     
- Misses      26597    26599       +2     
  Partials     2491     2491
Impacted Files Coverage Δ
models/repo_list.go 63.29% <0%> (-1.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e022a9...31096c9. Read the comment docs.

@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 26, 2018
@lafriks lafriks merged commit ce9a517 into go-gitea:master Nov 26, 2018
@adelowo adelowo deleted the fix_shadowed_variable branch November 26, 2018 15:23
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants