Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dependent issue searching when gitea is run in subpath #5392

Merged
merged 4 commits into from
Nov 25, 2018
Merged

Fix dependent issue searching when gitea is run in subpath #5392

merged 4 commits into from
Nov 25, 2018

Conversation

lafriks
Copy link
Member

@lafriks lafriks commented Nov 23, 2018

Fixes #5389

@lafriks lafriks added this to the 1.7.0 milestone Nov 23, 2018
@codecov-io
Copy link

codecov-io commented Nov 23, 2018 •
edited
Loading

Codecov Report

Merging #5392 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5392      +/-   ##
==========================================
- Coverage   37.45%   37.45%   -0.01%     
==========================================
  Files         312      312              
  Lines       46509    46509              
==========================================
- Hits        17419    17418       -1     
  Misses      26599    26599              
- Partials     2491     2492       +1
Impacted Files Coverage Δ
modules/process/manager.go 76.81% <0%> (-4.35%) ⬇️
models/repo_list.go 64.55% <0%> (+1.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e587e0...0cf404a. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 23, 2018
@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 24, 2018
@MarkusAmshove
Copy link
Contributor

I can confirm that this works :)

@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 25, 2018
@techknowlogick techknowlogick merged commit 499d132 into go-gitea:master Nov 25, 2018
@techknowlogick
Copy link
Member

@lafriks please send backport 😄

@lafriks lafriks deleted the fix/dep_suburl_repolink branch November 25, 2018 19:23
lafriks added a commit to lafriks-fork/gitea that referenced this pull request Nov 25, 2018
@lafriks
Fix dependent issue searching when gitea is run in subpath (go-gitea#…
a63211f 
…5392)
@lafriks lafriks mentioned this pull request Nov 25, 2018
Merged
@lafriks lafriks added the backport/done All backports for this PR have been created label Nov 25, 2018
techknowlogick pushed a commit that referenced this pull request Nov 26, 2018
@lafriks @techknowlogick
Fix dependent issue searching when gitea is run in subpath (#5392) (#…
328e38e 
…5400)
@lunny lunny mentioned this pull request Dec 8, 2018
Closed
7 tasks
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@Bwko Bwko Bwko approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.

API call to fetch issues when adding dependent issue doesn't take ROOT_URL into account
7 participants
@lafriks @codecov-io @MarkusAmshove @techknowlogick @lunny @Bwko @bkcsoft