Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API: '/orgs/:org/repos': return private repos with read access #5383

Merged
merged 2 commits into from
Nov 23, 2018
Merged

API: '/orgs/:org/repos': return private repos with read access #5383

merged 2 commits into from
Nov 23, 2018

Conversation

inxonic
Copy link
Contributor

@inxonic inxonic commented Nov 22, 2018 •
edited by lafriks

Fixes #5310 and #3829

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 22, 2018
@inxonic inxonic changed the title API: '/orgs/:org/repos': return private repos with read access (#5310) (#3829) API: '/orgs/:org/repos': return private repos with read access Nov 22, 2018
@codecov-io
Copy link

codecov-io commented Nov 22, 2018 •
edited

Codecov Report

Merging #5383 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5383      +/-   ##
==========================================
- Coverage   37.48%   37.47%   -0.02%     
==========================================
  Files         312      312              
  Lines       46507    46509       +2     
==========================================
- Hits        17432    17428       -4     
- Misses      26590    26593       +3     
- Partials     2485     2488       +3
Impacted Files Coverage Δ
routers/api/v1/user/repo.go 54.02% <100%> (+1.08%) ⬆️
models/repo_indexer.go 48.3% <0%> (-2.55%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49d9900...c78c106. Read the comment docs.

@techknowlogick techknowlogick added type/bug modifies/api This PR adds API routes or modifies them labels Nov 22, 2018
@lafriks lafriks added this to the 1.7.0 milestone Nov 23, 2018
@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 23, 2018
@go-gitea go-gitea deleted a comment from inxonic Nov 23, 2018
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 23, 2018
@techknowlogick techknowlogick merged commit 3379141 into go-gitea:master Nov 23, 2018
@lafriks
Copy link
Member

lafriks commented Nov 23, 2018

Please backport commit 3379141 to release/v1.6 branch

inxonic added a commit to inxonic/gitea that referenced this pull request Nov 23, 2018
@inxonic
Backported go-gitea#5383 on v1.6: API: '/orgs/:org/repos': return pri…
b56da9e 
…vate repos with read access (go-gitea#5310) (go-gitea#3829)

Signed-off-by: Daniel Balko <[email protected]>
@inxonic inxonic mentioned this pull request Nov 23, 2018
Merged
lafriks pushed a commit that referenced this pull request Nov 24, 2018
@inxonic @lafriks
Backported #5383 on v1.6: API: '/orgs/:org/repos': return private rep…
773addf 
…os with read access (#5310) (#3829) (#5393)

Signed-off-by: Daniel Balko <[email protected]>
@lafriks lafriks added the backport/done All backports for this PR have been created label Nov 24, 2018
@lunny lunny mentioned this pull request Feb 26, 2019
Closed
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@lafriks lafriks lafriks approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them type/bug
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.

API: '/orgs/:org/repos' should also return private repos, which the caller has read access to
5 participants
@inxonic @codecov-io @lafriks @techknowlogick @bkcsoft