Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dont' send assign webhooks when creating issue #5365

Merged
merged 1 commit into from
Nov 20, 2018
Merged

Dont' send assign webhooks when creating issue #5365

merged 1 commit into from
Nov 20, 2018

Conversation

lunny
Copy link
Member

@lunny lunny commented Nov 20, 2018

Should fix #5364

@lunny lunny added the type/bug label Nov 20, 2018
@codecov-io
Copy link

Codecov Report

Merging #5365 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5365      +/-   ##
==========================================
- Coverage   37.36%   37.35%   -0.01%     
==========================================
  Files         312      312              
  Lines       46436    46435       -1     
==========================================
- Hits        17349    17347       -2     
  Misses      26600    26600              
- Partials     2487     2488       +1
Impacted Files Coverage Δ
models/issue_assignees.go 40.33% <100%> (+1.86%) ⬆️
modules/process/manager.go 76.81% <0%> (-4.35%) ⬇️
models/repo_list.go 63.29% <0%> (-1.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a95e2d...82fbb8b. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 20, 2018
@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 20, 2018
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 20, 2018
@lafriks lafriks added this to the 1.7.0 milestone Nov 20, 2018
@techknowlogick techknowlogick merged commit 499bff4 into go-gitea:master Nov 20, 2018
@lafriks
Copy link
Member

lafriks commented Nov 20, 2018

@lunny Please send backport to release/1.6

lunny added a commit to lunny/gitea that referenced this pull request Nov 21, 2018
@lunny
dont' send assign webhooks when creating issue (go-gitea#5365)
4f40722
@lunny lunny mentioned this pull request Nov 21, 2018
Merged
@lunny lunny added the backport/done All backports for this PR have been created label Nov 21, 2018
@lunny lunny deleted the lunny/fix_create_issue_assign_webhook branch November 21, 2018 01:25
@lunny
Copy link
Member Author

lunny commented Nov 21, 2018

@lafriks done.

lunny added a commit that referenced this pull request Nov 21, 2018
@lunny
dont' send assign webhooks when creating issue (#5365) (#5369)
5d69703
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@adelowo adelowo adelowo approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.

Webhook issues send more event
6 participants
@lunny @codecov-io @lafriks @adelowo @techknowlogick @bkcsoft