Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed heatmap not working in mssql #5248

Merged
merged 2 commits into from
Nov 1, 2018

Conversation

kolaente
Copy link
Member

@kolaente kolaente commented Nov 1, 2018

Fixes #5212

@codecov-io
Copy link

codecov-io commented Nov 1, 2018

Codecov Report

Merging #5248 into master will increase coverage by <.01%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5248      +/-   ##
==========================================
+ Coverage   37.61%   37.61%   +<.01%     
==========================================
  Files         310      310              
  Lines       46040    46042       +2     
==========================================
+ Hits        17319    17320       +1     
- Misses      26242    26243       +1     
  Partials     2479     2479
Impacted Files Coverage Δ
models/user_heatmap.go 77.27% <75%> (-2.73%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa16562...f2f5f66. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 1, 2018
@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 1, 2018
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 1, 2018
@techknowlogick techknowlogick merged commit 225c489 into go-gitea:master Nov 1, 2018
@techknowlogick
Copy link
Member

@kolaente please send backport to release/v1.6 branch

@kolaente
Copy link
Member Author

kolaente commented Nov 1, 2018

@techknowlogick It looks like the heatmap isn't even included in 1.6, so there's no need to make a backport.

@kolaente kolaente deleted the fix/5212-heatmap-mssql branch November 1, 2018 19:34
@techknowlogick
Copy link
Member

@kolaente thanks for the reminder

@Cellebyte
Copy link

@kolaente, build a docker image from the master today which is integrated with our MsSQL Database.

The database schema is Latin1_General_CI_AI.

The return code is 500 "Internal Server Error".

Do we use the wrong schema?

{
    "message":"arg timestamp as int: strconv.ParseInt: parsing \"2018-11-13T00:00:00Z\": invalid syntax",
    "url":"https://godoc.org/github.com/go-gitea/go-sdk/gitea"
}

@lafriks
Copy link
Member

lafriks commented Nov 13, 2018

@Cellebyte please report new issue

@Cellebyte
Copy link

@kolaente, build a docker image from the master today which is integrated with our MsSQL Database.

The database schema is Latin1_General_CI_AI.

The return code is 500 "Internal Server Error".

Do we use the wrong schema?

{
    "message":"arg timestamp as int: strconv.ParseInt: parsing \"2018-11-13T00:00:00Z\": invalid syntax",
    "url":"https://godoc.org/github.com/go-gitea/go-sdk/gitea"
}

#5328

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dashboard heatmap always loading on mssql
7 participants