Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed wrong api request url for instances running in subfolders #5247

Merged
merged 3 commits into from
Nov 3, 2018
Merged

Fixed wrong api request url for instances running in subfolders #5247

merged 3 commits into from
Nov 3, 2018

Conversation

kolaente
Copy link
Member

@kolaente kolaente commented Nov 1, 2018

Fixes #5156

@kolaente kolaente mentioned this pull request Nov 1, 2018
Closed
7 tasks
@kolaente
Copy link
Member Author

kolaente commented Nov 1, 2018 •
edited
Loading

Should I directly send a backport to 1.6?

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 1, 2018
@codecov-io
Copy link

codecov-io commented Nov 1, 2018 •
edited
Loading

Codecov Report

Merging #5247 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5247      +/-   ##
==========================================
- Coverage   37.62%   37.61%   -0.01%     
==========================================
  Files         310      310              
  Lines       46042    46042              
==========================================
- Hits        17322    17319       -3     
- Misses      26241    26243       +2     
- Partials     2479     2480       +1
Impacted Files Coverage Δ
modules/process/manager.go 76.81% <0%> (-4.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 225c489...dab89c1. Read the comment docs.

@techknowlogick
Copy link
Member

@kolaente once this has been merged please do the backport. Thanks 😄

@kolaente
Copy link
Member Author

kolaente commented Nov 1, 2018

@techknowlogick only to 1.6 or also 1.5? (Since 1.5 isn't released yet)

@techknowlogick
Copy link
Member

@kolaente just 1.6 please 😄

@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 2, 2018
kolaente added a commit to kolaente/gitea that referenced this pull request Nov 2, 2018
@kolaente
Backported wrong api request url for instances running in subfolders (g…
70c3588 
…o-gitea#5247)
@kolaente kolaente mentioned this pull request Nov 2, 2018
Merged
@kolaente
Copy link
Member Author

kolaente commented Nov 2, 2018 •
edited
Loading

Backport is up: #5261

Awh shoot, I forgot to wait until this one is merged...

@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 3, 2018
@lafriks lafriks added this to the 1.7.0 milestone Nov 3, 2018
@lafriks lafriks added the backport/done All backports for this PR have been created label Nov 3, 2018
@lafriks lafriks merged commit 54259e2 into go-gitea:master Nov 3, 2018
techknowlogick pushed a commit that referenced this pull request Nov 3, 2018
@kolaente @techknowlogick
Backported wrong api request url for instances running in subfolders (#…
f95c966 
…5247) (#5261)
@kolaente kolaente deleted the fix/5156-wrong-api-dependency-url branch January 24, 2019 18:16
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@lafriks lafriks lafriks approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.

api request url for dependencies in issues is wrong
5 participants
@kolaente @codecov-io @techknowlogick @lafriks @bkcsoft