Serve audio files using HTML5 audio tag #5221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
templates/repo/view_file.tmpl
Outdated
| @@ -55,6 +55,11 @@ | |||
| <video controls src="{{EscapePound $.RawFileLink}}"> | |||
| <strong>{{.i18n.Tr "repo.video_not_supported_in_browser"}}</strong> | |||
| </video> | |||
| <img src="{{EscapePound $.RawFileLink}}"> | |||
There was a problem hiding this comment.
Why image tag? This would create a video tag, followed immediately by image tag
There was a problem hiding this comment.
Oops thanks, copy paste error
bkcsoft
added
the
lgtm/need 2
Codecov Report
@@ Coverage Diff @@
## master #5221 +/- ##
==========================================
- Coverage 37.49% 37.49% -0.01%
==========================================
Files 309 309
Lines 45827 45831 +4
==========================================
Hits 17185 17185
- Misses 26179 26183 +4
Partials 2463 2463
Continue to review full report at Codecov.
|
sapk
approved these changes
Oct 30, 2018
bkcsoft
added
lgtm/need 1
appleboy
approved these changes
Oct 30, 2018
bkcsoft
added
lgtm/done
lunny
approved these changes
Oct 30, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to how Gitea shows video files using HTML this enables audio files.
Closes #5206
Ref: #418