fix: Accept web-command cli flags if web-command is commited #5200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added flags of default cmd CmdWeb to app-wide flags * If command *is* specified app-wide flags are ignored Resolves: #5065 Signed-off-by: Berengar W. Lehr <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #5200 +/- ##
=========================================
Coverage ? 37.48%
=========================================
Files ? 310
Lines ? 45923
Branches ? 0
=========================================
Hits ? 17213
Misses ? 26236
Partials ? 2474Continue to review full report at Codecov.
|
bkcsoft
added
the
lgtm/need 2
main.go
Outdated
| @@ -13,6 +13,7 @@ import ( | |||
| "code.gitea.io/gitea/cmd" | |||
| "code.gitea.io/gitea/modules/log" | |||
| "code.gitea.io/gitea/modules/setting" | |||
|
|
|||
There was a problem hiding this comment.
Would you be able to remove this newline?
|
One nit, but once that is resolved I'll be happy to complete my review. Thanks for PR 😄 |
* broken windows need to be fixed * provides requested change
|
@techknowlogick nit was removed, is there anything else I can do? |
techknowlogick
approved these changes
Oct 30, 2018
bkcsoft
added
lgtm/need 1
adelowo
approved these changes
Oct 31, 2018
bkcsoft
added
lgtm/done
|
@HoffmannP please send back port to release/v1.6 |
techknowlogick
pushed a commit
that referenced
this pull request
Nov 1, 2018
* Added flags of default cmd CmdWeb to app-wide flags * If command *is* specified app-wide flags are ignored Backport of #5200 Signed-off-by: Berengar W. Lehr <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #5065
Signed-off-by: Berengar W. Lehr [email protected]