fix: Add secret to all webhook's payload where it has been missing

[HoffmannP]

affects webhooks for:

• Delete
• Fork
• IssueComment
• Release

This PR is paired with go-gitea/go-sdk#126

Resolves: #4732, #5173
Signed-off-by: Berengar W. Lehr [email protected]

[lunny]

@appleboy maybe you can review go-gitea/go-sdk#126

[appleboy]

@lunny Approve and merged.

[sapk]

@HoffmannP to update vendor please use the dep tool.

dep ensure -update code.gitea.io/sdk

[HoffmannP]

@sapk will do next time. Is this advice something to be added to the contribution guideline?

[lafriks]

@HoffmannP I think it was somewhere in guidelines. CI will not build otherwise so while it is not updated with go dep PR can not be merged

[sapk]

The vendoring section say that we use dep but not how to used it.
https://github.com/go-gitea/gitea/blob/master/CONTRIBUTING.md#vendoring

For a quick setup:

#Download the tool
go get -u github.com/golang/dep/cmd/dep
#Update the dep (need $GOPATH/bin in the $PATH)
dep ensure -update code.gitea.io/sdk
#Add Gopkg.toml Gopkg.lock vendor/
git add Gopkg.toml Gopkg.lock vendor/
#And you should be ready to commit the change and push it to the PR.

[HoffmannP]

@sapk I have no idea what I did wrong but files are changing that I never touched and the build is failing at places I never saw before

[sapk]

@HoffmannP you did nothing wrong.
You update the sdk to the lastest that include your change but also changes from others PR to sdk that were not yet merge in gitea (but validated in sdk).
The error of the CI is because you PR (or an other one to sdk) modify the response of some API call so the definition of the api (swagger file) need to be re-generated.
You should run:

make generate-swagger

This will update the file templates/swagger/v1_json.tmpl that need to be committed. Sorry for not thinking of it before. The CI tests are there to remind us of that 😄.

[HoffmannP]

All right than. Getting this done teaches me way more than I could've hoped for. Thank you for the explanation!

[HoffmannP]

Shouldn't #4960 be merged first as it explicitely references the changes to sdk in question? Leaving separate changes in different commits?

[codecov-io]

Codecov Report

Merging #5199 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5199      +/-   ##
==========================================
+ Coverage    37.5%   37.51%   +<.01%     
==========================================
  Files         309      309              
  Lines       45800    45800              
==========================================
+ Hits        17178    17180       +2     
+ Misses      26160    26158       -2     
  Partials     2462     2462

Impacted Files	Coverage Δ
models/repo_list.go	63.37% <0%> (+1.16%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48badd5...9f0c995. Read the comment docs.

[sapk]

@HoffmannP It shouldn't be blocking as the fields will just be ignored or empty. The sdk will just be already updated for other PR.

[techknowlogick]

@HoffmannP would you be able to send a backport PR to release/v1.6 branch ?

[HoffmannP]

@techknowlogick done