Fix sqlite lock #5176
Merged
Fix sqlite lock #5176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typeless
reviewed
Oct 25, 2018
models/repo.go
Outdated
| return repo.checkUnitUser(x, userID, isAdmin, unitType) | ||
| } | ||
|
|
||
| func (repo *Repository) checkUnitUser(e Engine, userID int64, isAdmin bool, unitType UnitType) bool { | ||
| if err := repo.getUnitsByUserID(x, userID, isAdmin); err != nil { |
There was a problem hiding this comment.
The parameter e should be used here?
There was a problem hiding this comment.
done and also fixed another place.
bkcsoft
added
the
lgtm/need 2
lafriks
approved these changes
Oct 25, 2018
bkcsoft
added
lgtm/need 1
Codecov Report
@@ Coverage Diff @@
## master #5176 +/- ##
=========================================
+ Coverage 37.49% 37.5% +<.01%
=========================================
Files 309 309
Lines 45786 45790 +4
=========================================
+ Hits 17169 17173 +4
Misses 26156 26156
Partials 2461 2461
Continue to review full report at Codecov.
|
appleboy
approved these changes
Oct 25, 2018
bkcsoft
added
lgtm/done
sapk
approved these changes
Oct 25, 2018
lunny
added a commit
to lunny/gitea
that referenced
this pull request
Oct 25, 2018
* fix sqlite lock * fix sqlite lock on getUnitType
lafriks
pushed a commit
that referenced
this pull request
Oct 25, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.