Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix showing pull request link when delete a branch #5166

Merged
merged 2 commits into from
Oct 28, 2018
Merged

Fix showing pull request link when delete a branch #5166

merged 2 commits into from
Oct 28, 2018

Conversation

lunny
Copy link
Member

@lunny lunny commented Oct 24, 2018

Will fix #5160

@lunny lunny added the type/bug label Oct 24, 2018
@lunny lunny added this to the 1.7.0 milestone Oct 24, 2018
@codecov-io
Copy link

codecov-io commented Oct 24, 2018 •
edited
Loading

Codecov Report

Merging #5166 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5166      +/-   ##
==========================================
+ Coverage   37.51%   37.51%   +<.01%     
==========================================
  Files         309      309              
  Lines       45800    45800              
==========================================
+ Hits        17180    17181       +1     
  Misses      26158    26158              
+ Partials     2462     2461       -1
Impacted Files Coverage Δ
models/repo_list.go 62.2% <0%> (-1.17%) ⬇️
models/repo_indexer.go 52.11% <0%> (+1.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb14458...7a67469. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 24, 2018
@JulienTant
Copy link
Contributor

Wow didn't think about that one at all. Thanks for the fix.

@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 25, 2018
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 28, 2018
@techknowlogick techknowlogick merged commit a2ee2a3 into go-gitea:master Oct 28, 2018
@lunny lunny deleted the lunny/fix_pr_link branch October 29, 2018 01:10
@adelowo adelowo mentioned this pull request Nov 6, 2018
Closed
3 tasks
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@techknowlogick techknowlogick techknowlogick approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.

When delete a branch, it should not show creating a new pull request hint on console.
6 participants
@lunny @codecov-io @JulienTant @techknowlogick @lafriks @bkcsoft