Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JSON result of empty array in heatmap data array #5154

Merged
merged 3 commits into from
Oct 24, 2018

Conversation

sapk
Copy link
Member

@sapk sapk commented Oct 23, 2018

Fix #5151 by init the array so that the JSON translation is not null but [].

  • some test

@codecov-io
Copy link

codecov-io commented Oct 23, 2018

Codecov Report

Merging #5154 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5154      +/-   ##
==========================================
- Coverage   37.49%   37.48%   -0.01%     
==========================================
  Files         309      309              
  Lines       45782    45783       +1     
==========================================
- Hits        17164    17162       -2     
  Misses      26157    26157              
- Partials     2461     2464       +3
Impacted Files Coverage Δ
models/user_heatmap.go 80% <100%> (+1.05%) ⬆️
modules/process/manager.go 76.81% <0%> (-4.35%) ⬇️
models/repo_indexer.go 50.84% <0%> (-1.28%) ⬇️
models/user.go 44.3% <0%> (+0.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 317ddb7...118470a. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 23, 2018
@techknowlogick techknowlogick added type/bug modifies/api This PR adds API routes or modifies them labels Oct 23, 2018
@lunny lunny added this to the 1.7.0 milestone Oct 24, 2018
@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 24, 2018
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 24, 2018
@lunny lunny merged commit 70ad461 into go-gitea:master Oct 24, 2018
@sapk sapk deleted the fix-5151 branch October 24, 2018 13:18
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

As a new user, the heatmap does not render until you have submitted the first commit.
6 participants