Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicated if bodies #5121

Merged
merged 2 commits into from
Oct 19, 2018

Conversation

cristaloleg
Copy link
Contributor

Found by go-critic dupBranchBody checker.

Possibly a bug? Maybe we should use different queries for different databases?

Log

models/user.go:381:2 dupBranchBody both branches in if statement has same body
models/user.go:400:2 dupBranchBody both branches in if statement has same body

@codecov-io
Copy link

codecov-io commented Oct 19, 2018

Codecov Report

Merging #5121 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5121      +/-   ##
==========================================
- Coverage    37.4%   37.39%   -0.01%     
==========================================
  Files         307      307              
  Lines       45553    45545       -8     
==========================================
- Hits        17038    17032       -6     
+ Misses      26060    26056       -4     
- Partials     2455     2457       +2
Impacted Files Coverage Δ
models/user.go 44.01% <0%> (+0.33%) ⬆️
modules/process/manager.go 76.81% <0%> (-4.35%) ⬇️
models/repo_indexer.go 50.84% <0%> (-1.28%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 616b8f4...a99200a. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 19, 2018
@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 19, 2018
@lunny lunny added the type/enhancement An improvement of existing functionality label Oct 19, 2018
@lunny lunny added this to the 1.7.0 milestone Oct 19, 2018
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 19, 2018
@techknowlogick techknowlogick added type/refactoring Existing code has been cleaned up. There should be no new functionality. lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. labels Oct 19, 2018
@techknowlogick techknowlogick merged commit a908b29 into go-gitea:master Oct 19, 2018
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants