Remove check for negative length

models/issue_label.go

@@ -134,7 +134,7 @@ func NewLabels(labels ...*Label) error {
 // If pass repoID as 0, then ORM will ignore limitation of repository
 // and can return arbitrary label with any valid ID.
 func getLabelInRepoByName(e Engine, repoID int64, labelName string) (*Label, error) {
- if len(labelName) <= 0 {
+ if len(labelName) == 0 {
  return nil, ErrLabelNotExist{0, repoID}
  }
 

models/org.go

@@ -677,7 +677,7 @@ func (env *accessibleReposEnv) Repos(page, pageSize int) ([]*Repository, error)
  }
 
  repos := make([]*Repository, 0, len(repoIDs))
- if len(repoIDs) <= 0 {
+ if len(repoIDs) == 0 {
  return repos, nil
  }
 
@@ -705,7 +705,7 @@ func (env *accessibleReposEnv) MirrorRepos() ([]*Repository, error) {
  }
 
  repos := make([]*Repository, 0, len(repoIDs))
- if len(repoIDs) <= 0 {
+ if len(repoIDs) == 0 {
  return repos, nil
  }
 

models/ssh_key.go

@@ -376,7 +376,7 @@ func calcFingerprint(publicKeyContent string) (string, error) {
 }
 
 func addKey(e Engine, key *PublicKey) (err error) {
- if len(key.Fingerprint) <= 0 {
+ if len(key.Fingerprint) == 0 {
  key.Fingerprint, err = calcFingerprint(key.Content)
  if err != nil {
  return err

modules/auth/auth.go

@@ -36,7 +36,7 @@ func SignedInID(ctx *macaron.Context, sess session.Store) int64 {
  // Check access token.
  if IsAPIPath(ctx.Req.URL.Path) {
  tokenSHA := ctx.Query("token")
- if len(tokenSHA) <= 0 {
+ if len(tokenSHA) == 0 {
  tokenSHA = ctx.Query("access_token")
  }
  if len(tokenSHA) == 0 {

modules/user/user_test.go

@@ -18,7 +18,7 @@ func getWhoamiOutput() (string, error) {
 
 func TestCurrentUsername(t *testing.T) {
  user := CurrentUsername()
- if len(user) <= 0 {
+ if len(user) == 0 {
  t.Errorf("expected non-empty user, got: %s", user)
  }
  // Windows whoami is weird, so just skip remaining tests

routers/api/v1/api.go

@@ -80,7 +80,7 @@ import (
 func sudo() macaron.Handler {
  return func(ctx *context.APIContext) {
  sudo := ctx.Query("sudo")
- if len(sudo) <= 0 {
+ if len(sudo) == 0 {
  sudo = ctx.Req.Header.Get("Sudo")
  }
 

routers/user/home.go

@@ -213,7 +213,7 @@ func Issues(ctx *context.Context) {
  return
  }
  }
- if len(userRepoIDs) <= 0 {
+ if len(userRepoIDs) == 0 {
  userRepoIDs = []int64{-1}
  }