Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use named const instead of a raw string #5115

Merged
merged 2 commits into from
Oct 20, 2018

Conversation

cristaloleg
Copy link
Contributor

Found by go-critic.

Log:

models/user.go:1390:18 namedConst use SearchOrderByAlphabetically instead of "name ASC"

@codecov-io
Copy link

codecov-io commented Oct 19, 2018

Codecov Report

Merging #5115 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5115      +/-   ##
==========================================
+ Coverage   37.39%   37.44%   +0.04%     
==========================================
  Files         307      307              
  Lines       45545    45545              
==========================================
+ Hits        17033    17053      +20     
+ Misses      26055    26037      -18     
+ Partials     2457     2455       -2
Impacted Files Coverage Δ
models/user.go 44.01% <100%> (ø) ⬆️
models/repo_indexer.go 56.35% <0%> (+5.5%) ⬆️
modules/indexer/repo.go 69.84% <0%> (+5.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 971dccd...927cf48. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 19, 2018
@lunny lunny added the type/enhancement An improvement of existing functionality label Oct 19, 2018
@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 19, 2018
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 19, 2018
@lunny lunny added type/refactoring Existing code has been cleaned up. There should be no new functionality. and removed type/enhancement An improvement of existing functionality labels Oct 20, 2018
@lunny lunny merged commit cabdf84 into go-gitea:master Oct 20, 2018
@lunny lunny added this to the 1.7.0 milestone Oct 20, 2018
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants