Implementation of Folder Jumping #511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreynering
added
the
type/feature
|
LGTM Very good. After go-gitea/git#23 being merged, please do update vendor e push another commit: |
tboerger
added
the
lgtm/need 1
|
Great feature, but I personally prefer the Github approach (greying out empty folders). Maybe you could add that? |
Bwko
reviewed
Dec 28, 2016
| @@ -1272,6 +1272,9 @@ footer .ui.language .menu { | |||
| .repository.file.list #repo-files-table tr:hover { | |||
| background-color: #ffffEE; | |||
| } | |||
| .repository.file.list #repo-files-table .jumpable-path { | |||
There was a problem hiding this comment.
Rule added to the less file
| {{else}} | ||
| {{index $subJumpablePath 0}} | ||
| {{end}} | ||
| </a> |
|
@sriio You feel done with this? in that case |
|
LGTM |
tboerger
added
lgtm/done
|
vendor updated and squash done |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple implementation of Folder Jumping
Comes with this PR