Add notification interface and refactor UI notifications #5085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunny
added
the
type/refactoring
Codecov Report
@@ Coverage Diff @@
## master #5085 +/- ##
=========================================
+ Coverage 37.39% 37.4% +<.01%
=========================================
Files 306 307 +1
Lines 45397 45552 +155
=========================================
+ Hits 16977 17037 +60
- Misses 25962 26060 +98
+ Partials 2458 2455 -3
Continue to review full report at Codecov.
|
bkcsoft
added
the
lgtm/need 2
jonasfranz
reviewed
Oct 15, 2018
routers/repo/issue.go
Outdated
| @@ -1014,6 +1014,8 @@ func UpdateIssueStatus(ctx *context.Context) { | |||
| ctx.ServerError("ChangeStatus", err) | |||
| return | |||
| } | |||
|
|
|||
| notification.NotifyIssueChangeStatus(ctx.User, issue, isClosed) | |||
There was a problem hiding this comment.
Only send notifications if status really change. In my understanding this will send a notification if isClosed = true and the issue is already closed.
|
Thank you for this PR. I think this re-factoring is really needed! |
jonasfranz
approved these changes
Oct 16, 2018
bkcsoft
added
lgtm/need 1
BetaCat0
reviewed
Oct 18, 2018
lunny
force-pushed
the
lunny/notification_ui
branch
from
da1627d
to
ef91809
Compare
|
@BetaCat0 done. |
BetaCat0
approved these changes
Oct 18, 2018
bkcsoft
added
lgtm/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request create a notification interface so that all notifications, i.e. ui, actions, webhooks, mails and etc. will only need to implement the interface. So that the code will be more easy. This is extract from #4001. It's the first step of serval pull requests from #4001. I think it will be easier to review.