Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use APP_NAME on home page #5048

Merged
merged 6 commits into from
Oct 18, 2018
Merged

Use APP_NAME on home page #5048

merged 6 commits into from
Oct 18, 2018

Conversation

mcnesium
Copy link
Contributor

@mcnesium mcnesium commented Oct 9, 2018

Would it make sense to actually use the configured app name on the home page?

@mcnesium
Use APP_NAME on home page
acc3284 
Would it make sense to actually use the configured app name on the home page?
@codecov-io
Copy link

codecov-io commented Oct 9, 2018 •
edited

Codecov Report

Merging #5048 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5048      +/-   ##
=========================================
- Coverage   37.41%   37.4%   -0.01%     
=========================================
  Files         306     306              
  Lines       45389   45389              
=========================================
- Hits        16981   16977       -4     
- Misses      25954   25956       +2     
- Partials     2454    2456       +2
Impacted Files Coverage Δ
models/repo_indexer.go 49.57% <0%> (-2.55%) ⬇️
models/repo_list.go 63.37% <0%> (+1.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb0c848...a1b4ceb. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 9, 2018
@techknowlogick techknowlogick added the topic/ui Change the appearance of the Gitea UI label Oct 9, 2018
@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 9, 2018
@coolaj86
Copy link
Contributor

coolaj86 commented Oct 9, 2018

I was considering making a PR for this myself. Thanks!

@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 9, 2018
@lafriks lafriks added this to the 1.7.0 milestone Oct 9, 2018
@lunny lunny merged commit 7bb4d61 into go-gitea:master Oct 18, 2018
@mcnesium mcnesium deleted the patch-1 branch October 18, 2018 07:49
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@appleboy appleboy appleboy approved these changes

@lafriks lafriks lafriks approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@mcnesium @codecov-io @coolaj86 @appleboy @lafriks @lunny @techknowlogick @bkcsoft @jonasfranz