started work on allowing pr approval/rejection... Untested though

models/review.go

@@ -9,6 +9,7 @@ import (
 
  "code.gitea.io/gitea/modules/log"
  "code.gitea.io/gitea/modules/util"
+ api "code.gitea.io/sdk/gitea"
  "github.com/go-xorm/xorm"
 
  "github.com/go-xorm/builder"
@@ -216,6 +217,34 @@ func createReview(e Engine, opts CreateReviewOptions) (*Review, error) {
  if _, err := e.Insert(review); err != nil {
  return nil, err
  }
+
+ var reviewHookType HookEventType
+ var action api.HookIssueAction
+
+ if opts.Type == ReviewTypeApprove {
+ reviewHookType = HookEventPullRequestApproved
+ action = api.HookPullRequestApproved
+ } else if opts.Type == ReviewTypeReject {
+ reviewHookType = HookEventPullRequestRejected
+ action = api.HookPullRequestRejected
+ } else {
+ // Webhook for a review comment does not exists
+ return review, nil
+ }
+
+ mode, _ := AccessLevel(opts.Issue.Poster.ID, opts.Issue.Repo)
+ if err := PrepareWebhooks(opts.Issue.Repo, reviewHookType, &api.PullRequestPayload{
+ Action: action,
+ Index: opts.Issue.Index,
+ PullRequest: opts.Issue.PullRequest.APIFormat(),
+ Repository: opts.Issue.Repo.APIFormat(mode),
+ Sender: opts.Reviewer.APIFormat(),
+ }); err != nil {
+ return nil, err
+ } else {
+ go HookQueue.Add(opts.Issue.Repo.RepoID)
+ }
+
  return review, nil
 }
 

models/webhook.go

@@ -425,15 +425,17 @@ type HookEventType string
 
 // Types of hook events
 const (
- HookEventCreate HookEventType = "create"
- HookEventDelete HookEventType = "delete"
- HookEventFork HookEventType = "fork"
- HookEventPush HookEventType = "push"
- HookEventIssues HookEventType = "issues"
- HookEventIssueComment HookEventType = "issue_comment"
- HookEventPullRequest HookEventType = "pull_request"
- HookEventRepository HookEventType = "repository"
- HookEventRelease HookEventType = "release"
+ HookEventCreate HookEventType = "create"
+ HookEventDelete HookEventType = "delete"
+ HookEventFork HookEventType = "fork"
+ HookEventPush HookEventType = "push"
+ HookEventIssues HookEventType = "issues"
+ HookEventIssueComment HookEventType = "issue_comment"
+ HookEventPullRequest HookEventType = "pull_request"
+ HookEventRepository HookEventType = "repository"
+ HookEventRelease HookEventType = "release"
+ HookEventPullRequestApproved HookEventType = "pr_approved"
+ HookEventPullRequestRejected HookEventType = "pr_rejected"
 )
 
 // HookRequest represents hook task request information.

options/locale/locale_en-US.ini

@@ -1089,7 +1089,7 @@ settings.event_issue_comment_desc = Issue comment created, edited, or deleted.
 settings.event_release = Release
 settings.event_release_desc = Release published, updated or deleted in a repository.
 settings.event_pull_request = Pull Request
-settings.event_pull_request_desc = Pull request opened, closed, reopened, edited, assigned, unassigned, label updated, label cleared or synchronized.
+settings.event_pull_request_desc = Pull request opened, closed, reopened, edited, approved, rejected, assigned, unassigned, label updated, label cleared or synchronized.
 settings.event_push = Push
 settings.event_push_desc = Git push to a repository.
 settings.event_repository = Repository