Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate random password #5023

Merged
merged 8 commits into from
Oct 30, 2018

Conversation

adelowo
Copy link
Member

@adelowo adelowo commented Oct 6, 2018

Fixes #4931

  • Added a new cli flag -random-password
  • Added a new cli flag -random-password-length for configuring length of generated password
  • Generate a random password with generate.GetRandomString

Thoughts ?

@codecov-io
Copy link

codecov-io commented Oct 6, 2018

Codecov Report

Merging #5023 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5023      +/-   ##
==========================================
+ Coverage   37.47%   37.48%   +0.01%     
==========================================
  Files         310      310              
  Lines       45935    45935              
==========================================
+ Hits        17213    17220       +7     
+ Misses      26244    26241       -3     
+ Partials     2478     2474       -4
Impacted Files Coverage Δ
models/repo_list.go 62.2% <0%> (-1.17%) ⬇️
models/repo_indexer.go 48.3% <0%> (+3.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0f614a...c01aeba. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 6, 2018
@lunny lunny added the type/enhancement An improvement of existing functionality label Oct 6, 2018
@lafriks
Copy link
Member

lafriks commented Oct 6, 2018

If implemented sending email should probably be optional with special flag

@adelowo
Copy link
Member Author

adelowo commented Oct 6, 2018

If implemented sending email should probably be optional with special flag

Will add that

@techknowlogick techknowlogick added this to the 1.7.0 milestone Oct 6, 2018
@adelowo
Copy link
Member Author

adelowo commented Oct 23, 2018

@lafriks I couldn't get emails to work... Would work on that and send another PR in the future

cmd/admin.go Outdated Show resolved Hide resolved
@lafriks lafriks added the type/changelog Adds the changelog for a new Gitea version label Oct 28, 2018
@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 28, 2018
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 30, 2018
@techknowlogick techknowlogick merged commit e5daa26 into go-gitea:master Oct 30, 2018
@adelowo adelowo deleted the generate_random_password branch October 31, 2018 11:12
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
@delvh delvh removed the type/changelog Adds the changelog for a new Gitea version label Oct 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal: gitea admin create-user random password
8 participants