Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(topic): search keyword by splitting provided values by , #4939

Merged
merged 3 commits into from
Oct 18, 2018
Merged

feat(topic): search keyword by splitting provided values by , #4939

merged 3 commits into from
Oct 18, 2018

Conversation

appleboy
Copy link
Member

@appleboy appleboy added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Sep 15, 2018
@appleboy appleboy added this to the 1.6.0 milestone Sep 15, 2018
@appleboy appleboy self-assigned this Sep 15, 2018
@bkcsoft bkcsoft added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Sep 15, 2018
@lafriks
Copy link
Member

lafriks commented Sep 15, 2018

In such cases it should search for repositories where both tags are present (and not or)

@jonasfranz
Copy link
Member

Moved this to 1.7 since we're in feature freeze.

@jonasfranz jonasfranz modified the milestones: 1.6.0, 1.7.0 Sep 17, 2018
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 18, 2018
@codecov-io
Copy link

Codecov Report

Merging #4939 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4939      +/-   ##
=========================================
- Coverage   37.41%   37.4%   -0.01%     
=========================================
  Files         306     306              
  Lines       45379   45381       +2     
=========================================
- Hits        16978   16977       -1     
- Misses      25947   25949       +2     
- Partials     2454    2455       +1
Impacted Files Coverage Δ
models/repo_list.go 62.2% <100%> (+0.44%) ⬆️
modules/process/manager.go 76.81% <0%> (-4.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e79e924...9dc2eb7. Read the comment docs.

@techknowlogick techknowlogick merged commit 486e989 into go-gitea:master Oct 18, 2018
@appleboy appleboy deleted the topic_search branch October 18, 2018 03:16
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@jonasfranz jonasfranz jonasfranz approved these changes

Assignees

@appleboy appleboy

Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@appleboy @lafriks @jonasfranz @codecov-io @techknowlogick @bkcsoft @lunny