Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use native go method to get current user rather than environment variable #4930

Merged
merged 4 commits into from
Oct 18, 2018
Merged

Use native go method to get current user rather than environment variable #4930

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
70a9f4d
Use native go method to get current user rather than environment var
SagePtr Sep 13, 2018
02b4617
Use t.Skip instead of return in test
SagePtr Sep 18, 2018
e8d104a
Merge branch 'master' into golang-currentuser
lunny Oct 18, 2018
1ea5eea
Merge branch 'master' into golang-currentuser
lunny Oct 18, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use t.Skip instead of return in test
  • Loading branch information
@SagePtr
SagePtr committed Sep 18, 2018
commit 02b461735acb6d4780ec0ab7e34b9147a6b67d07
2 changes: 1 addition & 1 deletion modules/user/user_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ func TestCurrentUsername(t *testing.T) {
}
// Windows whoami is weird, so just skip remaining tests
if runtime.GOOS == "windows" {
return
t.Skip("skipped test because of weird whoami on Windows")
}
whoami, err := getWhoamiOutput()
if err != nil {
Expand Down