Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for search by uid #4876

Merged
merged 4 commits into from
Oct 18, 2018
Merged

Add support for search by uid #4876

merged 4 commits into from
Oct 18, 2018

Conversation

zeripath
Copy link
Contributor

@zeripath zeripath commented Sep 5, 2018

At the moment there is no way to search for users by their ID using the API. Gitlab does this by overloading the /users/{username} API routes to allow searching with user ID. Rather than go that route this pull request adds a uid parameter to the /users/search API and allows searching by user ID.

models/user.go Outdated Show resolved Hide resolved
@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 5, 2018
@zeripath zeripath force-pushed the search-by-uid branch 3 times, most recently from ee6a892 to d866399 Compare September 5, 2018 21:28
@codecov-io
Copy link

codecov-io commented Sep 5, 2018

Codecov Report

Merging #4876 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4876      +/-   ##
==========================================
- Coverage    37.4%   37.38%   -0.02%     
==========================================
  Files         306      306              
  Lines       45389    45397       +8     
==========================================
- Hits        16978    16972       -6     
- Misses      25956    25967      +11     
- Partials     2455     2458       +3
Impacted Files Coverage Δ
models/user.go 43.67% <0%> (-0.13%) ⬇️
routers/api/v1/user/user.go 9.8% <0%> (-0.51%) ⬇️
models/repo_indexer.go 48.3% <0%> (-3.82%) ⬇️
modules/process/manager.go 81.15% <0%> (+4.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7bb4d61...e489bb1. Read the comment docs.

@lunny lunny added the modifies/api This PR adds API routes or modifies them label Sep 6, 2018
@lunny lunny added this to the 1.7.0 milestone Sep 6, 2018
@lunny lunny added the type/enhancement An improvement of existing functionality label Sep 7, 2018
@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 7, 2018
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 9, 2018
@zeripath zeripath force-pushed the search-by-uid branch 3 times, most recently from b65da14 to 7bf8856 Compare September 16, 2018 19:29
@zeripath zeripath force-pushed the search-by-uid branch 2 times, most recently from 92df673 to cdcfed7 Compare September 20, 2018 19:47
@zeripath zeripath force-pushed the search-by-uid branch 2 times, most recently from f3aaa0d to f7e00cf Compare September 25, 2018 16:57
Signed-off-by: Andrew Thornton <[email protected]>
@lunny lunny merged commit dd62ca7 into go-gitea:master Oct 18, 2018
@zeripath zeripath deleted the search-by-uid branch October 20, 2018 17:46
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants