Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Dutch translations to the landingpage #487

Merged
merged 1 commit into from
Dec 27, 2016
Merged

Conversation

Bwko
Copy link
Member

@Bwko Bwko commented Dec 26, 2016

No description provided.

@@ -1,4 +1,4 @@
app_desc=Een eenvoudige zelfgehoste Git service geschreven in Go
app_desc=A painless self-hosted Git service.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change necessary?

Copy link
Member Author

@Bwko Bwko Dec 26, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see A painless self-hosted Git service as a slogan. In Dutch it's not common to translate slogans.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert that, it have been translated for all languages.

@andreynering
Copy link
Contributor

Beside the comment, LGTM

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Dec 26, 2016
@lunny lunny added this to the 1.1.0 milestone Dec 27, 2016
@lunny lunny added the type/docs This PR mainly updates/creates documentation label Dec 27, 2016
@lunny
Copy link
Member

lunny commented Dec 27, 2016

trusted LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 27, 2016
@andreynering andreynering merged commit ba85f68 into go-gitea:master Dec 27, 2016
@Bwko Bwko deleted the NL branch December 27, 2016 13:31
@Bwko Bwko mentioned this pull request Dec 29, 2016
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/docs This PR mainly updates/creates documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants