Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to add organization members as collaborators on organization owned repositories #4748

Merged
merged 4 commits into from
Nov 30, 2018
Merged

Allow to add organization members as collaborators on organization owned repositories #4748

merged 4 commits into from
Nov 30, 2018

Conversation

adelowo
Copy link
Member

@adelowo adelowo commented Aug 19, 2018

Fixes #4507

Deleted the translation text since I couldn't find it being used elsewhere with ag "settings.user_is_org_member"

@lafriks
Copy link
Member

lafriks commented Aug 19, 2018

Won't there be side effects when checking rights?

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 19, 2018
@adelowo
Copy link
Member Author

adelowo commented Aug 19, 2018

I just tried regular pushing via the cli and viewing the repo via the UI..
I could run more checks but if you do know of a potential side effect kindly inform me so I can verify

@codecov-io
Copy link

codecov-io commented Aug 19, 2018 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@a7ee4a6). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4748   +/-   ##
=========================================
  Coverage          ?   37.56%           
=========================================
  Files             ?      317           
  Lines             ?    46822           
  Branches          ?        0           
=========================================
  Hits              ?    17588           
  Misses            ?    26735           
  Partials          ?     2499
Impacted Files Coverage Δ
routers/repo/setting.go 11.2% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7ee4a6...33ff015. Read the comment docs.

@lafriks
Copy link
Member

lafriks commented Aug 19, 2018

What if someone is added to the team with less settings for same repo, will there won't be mismatch when accessing ui

@lunny lunny added the type/enhancement An improvement of existing functionality label Aug 20, 2018
@adelowo
Copy link
Member Author

adelowo commented Aug 21, 2018

Would update this comment as @lafriks after extensive testing

@adelowo
Copy link
Member Author

adelowo commented Sep 1, 2018

I am yet to find any unexpected side effects

@lunny lunny added this to the 1.7.0 milestone Sep 7, 2018
@lunny
Copy link
Member

lunny commented Nov 30, 2018

@lafriks Since #5314 has supported permission check for organization member as a collaborator, I think this is meaningful. See https://github.com/go-gitea/gitea/blob/master/models/repo_permission.go#L142 .

@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 30, 2018
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 30, 2018
@adelowo
Copy link
Member Author

adelowo commented Nov 30, 2018

Heads up to anyone merging this. Can you kindly verify the deleted translation text is still not being used ?

@lafriks
Copy link
Member

lafriks commented Nov 30, 2018

@adelowo does not seems to

@lafriks lafriks merged commit 0787056 into go-gitea:master Nov 30, 2018
@lafriks lafriks changed the title Allow organization members to be added as collaborators on an org repo Allow to add organization members as collaborators on organization owned repositories Nov 30, 2018
@lafriks lafriks added the type/changelog Adds the changelog for a new Gitea version label Nov 30, 2018
@adelowo adelowo deleted the add_user_as_collaborator_to_organization_repo branch November 30, 2018 09:19
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
@delvh delvh removed the type/changelog Adds the changelog for a new Gitea version label Oct 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.

Proposal: Adding organization members as collaborators on org-owned repos
6 participants
@adelowo @lafriks @codecov-io @lunny @bkcsoft @delvh