Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix query parameter name comment in issue API #4421

Merged
merged 3 commits into from
Jul 12, 2018
Merged

Fix query parameter name comment in issue API #4421

merged 3 commits into from
Jul 12, 2018

Conversation

lafriks
Copy link
Member

@lafriks lafriks commented Jul 11, 2018

Fix typo in swagger description

@lafriks lafriks added the type/docs This PR mainly updates/creates documentation label Jul 11, 2018
@lafriks lafriks added this to the 1.6.0 milestone Jul 11, 2018
@bkcsoft bkcsoft added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jul 11, 2018
@codecov-io
Copy link

codecov-io commented Jul 11, 2018 •
edited

Codecov Report

Merging #4421 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4421   +/-   ##
=======================================
  Coverage   20.06%   20.06%           
=======================================
  Files         153      153           
  Lines       30769    30769           
=======================================
  Hits         6174     6174           
  Misses      23652    23652           
  Partials      943      943
Impacted Files Coverage Δ
routers/api/v1/repo/issue_comment.go 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6b5120...b04bf3c. Read the comment docs.

@lunny
Copy link
Member

lunny commented Jul 12, 2018

LGTM

@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 12, 2018
@lafriks lafriks merged commit 659bc72 into go-gitea:master Jul 12, 2018
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jonasfranz jonasfranz jonasfranz approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/docs This PR mainly updates/creates documentation
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@lafriks @codecov-io @lunny @jonasfranz @bkcsoft @techknowlogick