Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug when deleting a release #4207

Merged
merged 2 commits into from
Jun 12, 2018
Merged

Fix bug when deleting a release #4207

merged 2 commits into from
Jun 12, 2018

Conversation

lunny
Copy link
Member

@lunny lunny commented Jun 10, 2018

Fix the panic reported by #4205 caused by #3981.

@lunny lunny added the type/bug label Jun 10, 2018
@lunny lunny added this to the 1.5.0 milestone Jun 10, 2018
@codecov-io
Copy link

codecov-io commented Jun 10, 2018 •
edited
Loading

Codecov Report

Merging #4207 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4207      +/-   ##
==========================================
- Coverage   19.97%   19.96%   -0.01%     
==========================================
  Files         153      153              
  Lines       30514    30518       +4     
==========================================
  Hits         6094     6094              
- Misses      23506    23510       +4     
  Partials      914      914
Impacted Files Coverage Δ
models/release.go 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 908e894...c988b27. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 10, 2018
@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 12, 2018
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 12, 2018
@techknowlogick techknowlogick merged commit 406031d into go-gitea:master Jun 12, 2018
@techknowlogick techknowlogick mentioned this pull request Jun 12, 2018
Closed
7 tasks
@lunny lunny deleted the lunny/fix_del_release branch June 13, 2018 01:43
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@appleboy appleboy appleboy approved these changes

@lafriks lafriks lafriks approved these changes

@sapk sapk sapk approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.
7 participants
@lunny @codecov-io @appleboy @lafriks @sapk @techknowlogick @bkcsoft