Fix to 3819 - Filtering issues by tags on main screen issues #3824
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3824 +/- ##
==========================================
+ Coverage 37.5% 37.51% +<.01%
==========================================
Files 309 309
Lines 45798 45800 +2
==========================================
+ Hits 17176 17181 +5
+ Misses 26159 26158 -1
+ Partials 2463 2461 -2
Continue to review full report at Codecov.
|
bkcsoft
added
the
lgtm/need 2
|
Just commenting here with issue ID so GitHub links them: #3819 |
routers/user/home.go
Outdated
| @@ -249,6 +249,10 @@ func Issues(ctx *context.Context) { | |||
|
|
|||
| opts.Page = page | |||
| opts.PageSize = setting.UI.IssuePagingNum | |||
|
|
|||
| selectLabels := ctx.Query("labels") | |||
| opts.Labels = selectLabels | |||
There was a problem hiding this comment.
Replace this with:
opts.Labels = ctx.Query("labels")There was a problem hiding this comment.
@JonasFranzDEV done!
|
I don't understand why Drone generates errors when compiling. I have updated the branch but It seems Drone couldn't get updated sources. @techknowlogick Can you help me ? |
|
@rvillablanca This is an issue with Github where sometimes it caches old information. Let me re-trigger drone and likely the updated information will be loaded. |
|
@JonasFranzDEV need your approval |
bkcsoft
added
lgtm/need 1
|
@naiba This needs two successful approvals before it can be merged. |
|
@techknowlogick thank you, but when does the bot release 1.6.0? |
|
@JonasFranzDEV need your approval. |
bkcsoft
added
lgtm/done
|
@rvillablanca thanks for the PR. Would you be able to backport this commit to the release/v1.6 branch? If you need any assistance or clarification please let me know and I'd be happy to help. |
|
@techknowlogick I have created a PR #5219 for this purpose 👍 |
techknowlogick
added
backport/done
|
@techknowlogick I think we should keep the backport label even if this is merged. |
|
@lunny ok. |
This PR solves the issue #3819 where you can't filter issues by pressing on the tags.
Because there is a Default label set, there are many tags with same color and name like
bug, but they have differents id so when you filter by pressing in one tag, you are filtering only for one repo.Maybe this could be improved with another PR.