Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: show Clipboard button if disable HTTP of git protocol #3773

Merged
merged 2 commits into from
Apr 9, 2018
Merged

fix: show Clipboard button if disable HTTP of git protocol #3773

merged 2 commits into from
Apr 9, 2018

Conversation

appleboy
Copy link
Member

@appleboy appleboy commented Apr 9, 2018

fix #3771

snip20180409_5

@appleboy appleboy added type/bug topic/ui Change the appearance of the Gitea UI labels Apr 9, 2018
@appleboy appleboy added this to the 1.5.0 milestone Apr 9, 2018
@appleboy appleboy mentioned this pull request Apr 9, 2018
Closed
2 tasks
@codecov-io
Copy link

codecov-io commented Apr 9, 2018 •
edited
Loading

Codecov Report

Merging #3773 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3773   +/-   ##
=======================================
  Coverage   22.91%   22.91%           
=======================================
  Files         124      124           
  Lines       24750    24750           
=======================================
  Hits         5672     5672           
  Misses      18216    18216           
  Partials      862      862

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update daf70d3...88d44d1. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 9, 2018
@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 9, 2018
@lunny
Copy link
Member

lunny commented Apr 9, 2018

LGTM

@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 9, 2018
@lunny lunny merged commit 30c81a1 into go-gitea:master Apr 9, 2018
@appleboy appleboy mentioned this pull request Apr 9, 2018
Merged
@lunny lunny added backport/done All backports for this PR have been created backport/v1.4 labels Apr 9, 2018
appleboy added a commit that referenced this pull request Apr 9, 2018
@appleboy
Backport: fix: show Clipboard button if disable HTTP of git protocol #…
251e1b6 
…3773 (#3774)
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.

Copy to Clipboard button is missing when SSH is enabled, HTTP is disabled.
5 participants
@appleboy @codecov-io @lunny @lafriks @bkcsoft