Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix go vet error (#3740) #3744

Merged
merged 1 commit into from
Mar 30, 2018
Merged

fix go vet error (#3740) #3744

merged 1 commit into from
Mar 30, 2018

Conversation

lunny
Copy link
Member

@lunny lunny commented Mar 30, 2018

back port from #3740 and will fix broken test.

@lunny lunny added this to the 1.4.1 milestone Mar 30, 2018
@lunny lunny mentioned this pull request Mar 30, 2018
Merged
@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Mar 30, 2018
@lafriks
Copy link
Member

lafriks commented Mar 30, 2018

Make LG-TM work

@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 30, 2018
@lafriks lafriks merged commit 6c6d1ff into go-gitea:release/v1.4 Mar 30, 2018
@lunny lunny deleted the lunny/fix_vet_2 branch March 31, 2018 00:00
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Bwko Bwko Bwko approved these changes

@jonasfranz jonasfranz jonasfranz approved these changes

@lafriks lafriks lafriks approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/testing
Projects
None yet
Milestone
1.4.1
Development

Successfully merging this pull request may close these issues.
6 participants
@lunny @lafriks @jonasfranz @Bwko @tboerger @bkcsoft