Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't write to log NoCommitterAccount #3621

Merged
merged 3 commits into from
Mar 4, 2018
Merged

Don't write to log NoCommitterAccount #3621

merged 3 commits into from
Mar 4, 2018

Conversation

thehowl
Copy link
Contributor

@thehowl thehowl commented Mar 3, 2018

It's way too verbose, and the information is also printed to the user
already. Fixes #3602.

It's way too verbose, and the information is also printed to the user
already. Fixes #3602.
@codecov-io
Copy link

codecov-io commented Mar 3, 2018

Codecov Report

Merging #3621 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3621      +/-   ##
==========================================
- Coverage   36.15%   36.14%   -0.01%     
==========================================
  Files         285      285              
  Lines       40921    40924       +3     
==========================================
  Hits        14794    14794              
- Misses      23953    23957       +4     
+ Partials     2174     2173       -1
Impacted Files Coverage Δ
models/gpg_key.go 55.87% <0%> (-0.54%) ⬇️
models/repo_indexer.go 48.3% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78b54b4...93f37a1. Read the comment docs.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 3, 2018
@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 3, 2018
@lunny
Copy link
Member

lunny commented Mar 3, 2018

@thehowl You should determine if the err is IsUserNotExist. Only that error you could ignore the log.

@thehowl
Copy link
Contributor Author

thehowl commented Mar 3, 2018

Done.

@lunny
Copy link
Member

lunny commented Mar 3, 2018

@thehowl
Copy link
Contributor Author

thehowl commented Mar 3, 2018

Refresh the change set ;). I remembered immediately after I committed

@lunny
Copy link
Member

lunny commented Mar 3, 2018

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 3, 2018
@lunny lunny added this to the 1.5.0 milestone Mar 3, 2018
@lunny lunny merged commit b730498 into go-gitea:master Mar 4, 2018
@thehowl thehowl deleted the ignore-nocommitteraccount branch April 22, 2018 20:02
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/miscellaneous
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NoCommitterAccount: user does not exist
5 participants