Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix gpg expired bug when time is zero #3584

Merged
merged 1 commit into from
Feb 26, 2018
Merged

Fix gpg expired bug when time is zero #3584

merged 1 commit into from
Feb 26, 2018

Conversation

lunny
Copy link
Member

@lunny lunny commented Feb 26, 2018

will fix #3573

@lunny lunny added this to the 1.5.0 milestone Feb 26, 2018
@codecov-io
Copy link

Codecov Report

Merging #3584 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3584      +/-   ##
==========================================
- Coverage   35.79%   35.79%   -0.01%     
==========================================
  Files         285      285              
  Lines       40866    40868       +2     
==========================================
  Hits        14630    14630              
- Misses      24067    24068       +1     
- Partials     2169     2170       +1
Impacted Files Coverage Δ
modules/util/time_stamp.go 72.72% <0%> (-7.28%) ⬇️
models/repo_indexer.go 48.3% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 521945a...7d2bcff. Read the comment docs.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 26, 2018
@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 26, 2018
@sapk
Copy link
Member

sapk commented Feb 26, 2018

I think simply checking against zero should be ok (not tested) but that is good too.

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 26, 2018
@lafriks lafriks merged commit 769ab1e into go-gitea:master Feb 26, 2018
@lunny lunny deleted the lunny/fix_gpg_expire_bug branch February 26, 2018 15:11
@lafriks lafriks added the backport/done All backports for this PR have been created label May 2, 2018
lafriks pushed a commit to lafriks-fork/gitea that referenced this pull request May 2, 2018
@lunny @lafriks
fix gpg expired bug when time is zero (go-gitea#3584)
b1c050f
@lafriks lafriks mentioned this pull request May 2, 2018
Merged
appleboy pushed a commit that referenced this pull request May 2, 2018
@lafriks @appleboy
fix gpg expired bug when time is zero (#3584) (#3884)
adbf576
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@sapk sapk sapk approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.

GPG keys that do not expire default their expiry time to 0001-01-01
5 participants
@lunny @codecov-io @sapk @lafriks @tboerger