Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add doctype to go-get=1 reponse #3423

Merged
merged 2 commits into from
Jan 29, 2018
Merged

Add doctype to go-get=1 reponse #3423

merged 2 commits into from
Jan 29, 2018

Conversation

lafriks
Copy link
Member

@lafriks lafriks commented Jan 28, 2018 •
edited

Based on gogs/gogs#4938

Currently godoc is not recognizing go-get responses: https://godoc.org/try.gitea.io/gitea/gitea

@lafriks lafriks added this to the 1.4.0 milestone Jan 28, 2018
@codecov-io
Copy link

codecov-io commented Jan 28, 2018 •
edited

Codecov Report

❗ No coverage uploaded for pull request base (master@3968c11). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3423   +/-   ##
=========================================
  Coverage          ?   35.57%           
=========================================
  Files             ?      281           
  Lines             ?    40593           
  Branches          ?        0           
=========================================
  Hits              ?    14440           
  Misses            ?    24011           
  Partials          ?     2142
Impacted Files Coverage Δ
modules/context/context.go 46.97% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3968c11...06b963a. Read the comment docs.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 28, 2018
@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 28, 2018
@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 29, 2018
@lafriks lafriks merged commit 28b8189 into go-gitea:master Jan 29, 2018
@lafriks lafriks deleted the fix/godoc_goget branch January 29, 2018 01:12
@lafriks lafriks mentioned this pull request Jan 29, 2018
Merged
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@appleboy appleboy appleboy approved these changes

@techknowlogick techknowlogick techknowlogick approved these changes

@ethantkoenig ethantkoenig ethantkoenig approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@lafriks @codecov-io @appleboy @techknowlogick @ethantkoenig @tboerger