Fix bug when a user delete but assigned on issue #3318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunny
force-pushed
the
lunny/fix_comment_user_del
branch
from
fdd8ff7
to
cc2a128
Compare
Codecov Report
@@ Coverage Diff @@
## master #3318 +/- ##
==========================================
- Coverage 35.09% 35.07% -0.02%
==========================================
Files 279 279
Lines 40522 40526 +4
==========================================
- Hits 14220 14215 -5
- Misses 24201 24209 +8
- Partials 2101 2102 +1
Continue to review full report at Codecov.
|
tboerger
added
the
lgtm/need 2
appleboy
approved these changes
Jan 7, 2018
tboerger
added
lgtm/need 1
lafriks
approved these changes
Jan 7, 2018
tboerger
added
lgtm/done
bkcsoft
reviewed
Jan 8, 2018
| if !IsErrUserNotExist(err) { | ||
| return err | ||
| } | ||
| c.OldAssignee = NewGhostUser() |
There was a problem hiding this comment.
Issue is unassigned afaik, this is just comment that issue was assigned to user
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wiil fix #3314