Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spacing to global error message #31826

Merged
merged 2 commits into from
Aug 14, 2024

Conversation

sebluy
Copy link
Contributor

@sebluy sebluy commented Aug 13, 2024

Fixes #31717.

Include Typescript files in Tailwind config so they can be pre-processed.

Screenshot from 2024-08-13 08-44-33

Update Tailwind config to include Typescript files.
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 13, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 13, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 13, 2024
@lunny lunny added type/bug topic/ui Change the appearance of the Gitea UI labels Aug 13, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 14, 2024
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Aug 14, 2024
@lunny lunny enabled auto-merge (squash) August 14, 2024 01:53
@lunny lunny added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Aug 14, 2024
@lunny lunny merged commit 7569a47 into go-gitea:main Aug 14, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone Aug 14, 2024
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Aug 14, 2024
zjjhot added a commit to zjjhot/gitea that referenced this pull request Aug 14, 2024
* giteaofficial/main:
  Add spacing to global error message (go-gitea#31826)
  [skip ci] Updated translations via Crowdin
  Fixes for unreachable project issues when transfer repository from organization (go-gitea#31770)
4kProgrammer pushed a commit to 4kProgrammer/gitea that referenced this pull request Aug 20, 2024
Fixes go-gitea#31717.

Include Typescript files in Tailwind config so they can be
pre-processed.

![Screenshot from 2024-08-13
08-44-33](https://github.com/user-attachments/assets/196d7801-e299-4000-8b39-cd9f89917f17)
4kProgrammer pushed a commit to 4kProgrammer/gitea that referenced this pull request Aug 20, 2024
Squashed commit:

[e1468e2] Fixes for unreachable project issues when transfer repository from organization (go-gitea#31770)
dfhgfdhfghfg
When transferring repositories that have issues linked to a project
board to another organization, the issues remain associated with the
original project board. This causes the columns in the project board to
become bugged, making it difficult to move other issues in or out of the
affected columns. As a solution, I removed the issue relations since the
other organization does not have this project table.

Fix for go-gitea#31538

Co-authored-by: Jason Song <[email protected]>

[c39643f] fghfghf

[38a09ea] render plain text file if the LFS object doesn't exist (go-gitea#31812)gfgdfg

We had an issue where a repo was using LFS to store a file, but the user
did not push the file. When trying to view the file, Gitea returned a
500 HTTP status code referencing `ErrLFSObjectNotExist`. It appears the
intent was the render this file as plain text, but the conditional was
flipped. I've also added a test to verify that the file is rendered as
plain text.

[2477511] Add spacing to global error message (go-gitea#31826)

Fixes go-gitea#31717.

Include Typescript files in Tailwind config so they can be
pre-processed.

![Screenshot from 2024-08-13
08-44-33](https://github.com/user-attachments/assets/196d7801-e299-4000-8b39-cd9f89917f17)

[5bcab0b] [skip ci] Updated translations via Crowdin

[fe7c941] Scroll images in project issues separately from the remaining issue (go-gitea#31683)

As discussed in go-gitea#31667 & go-gitea#26561, when a card on a Project contains
images, they can overflow the card on its containing column. This aims
to fix this issue via snapping scrollbars.

---
Issue go-gitea#31667 is open to discussion as there should be room for
improvement.

[8883d99] Support issue template assignees (go-gitea#31083)

Resolve go-gitea#13955
4kProgrammer pushed a commit to 4kProgrammer/gitea that referenced this pull request Aug 20, 2024
Squashed commit:

[e1468e2] Fixes for unreachable project issues when transfer repository from organization (go-gitea#31770)
dfhgfdhfghfg
When transferring repositories that have issues linked to a project
board to another organization, the issues remain associated with the
original project board. This causes the columns in the project board to
become bugged, making it difficult to move other issues in or out of the
affected columns. As a solution, I removed the issue relations since the
other organization does not have this project table.

Fix for go-gitea#31538

Co-authored-by: Jason Song <[email protected]>

[c39643f] fghfghf

[38a09ea] render plain text file if the LFS object doesn't exist (go-gitea#31812)gfgdfg

We had an issue where a repo was using LFS to store a file, but the user
did not push the file. When trying to view the file, Gitea returned a
500 HTTP status code referencing `ErrLFSObjectNotExist`. It appears the
intent was the render this file as plain text, but the conditional was
flipped. I've also added a test to verify that the file is rendered as
plain text.

[2477511] Add spacing to global error message (go-gitea#31826)

Fixes go-gitea#31717.

Include Typescript files in Tailwind config so they can be
pre-processed.

![Screenshot from 2024-08-13
08-44-33](https://github.com/user-attachments/assets/196d7801-e299-4000-8b39-cd9f89917f17)

[5bcab0b] [skip ci] Updated translations via Crowdin

[fe7c941] Scroll images in project issues separately from the remaining issue (go-gitea#31683)

As discussed in go-gitea#31667 & go-gitea#26561, when a card on a Project contains
images, they can overflow the card on its containing column. This aims
to fix this issue via snapping scrollbars.

---
Issue go-gitea#31667 is open to discussion as there should be room for
improvement.

[8883d99] Support issue template assignees (go-gitea#31083)

Resolve go-gitea#13955
4kProgrammer pushed a commit to 4kProgrammer/gitea that referenced this pull request Aug 20, 2024
Squashed commit:

[e1468e2] Fixes for unreachable project issues when transfer repository from organization (go-gitea#31770)
dfhgfdhfghfg
When transferring repositories that have issues linked to a project
board to another organization, the issues remain associated with the
original project board. This causes the columns in the project board to
become bugged, making it difficult to move other issues in or out of the
affected columns. As a solution, I removed the issue relations since the
other organization does not have this project table.

Fix for go-gitea#31538

Co-authored-by: Jason Song <[email protected]>

[c39643f] fghfghf

[38a09ea] render plain text file if the LFS object doesn't exist (go-gitea#31812)gfgdfg

We had an issue where a repo was using LFS to store a file, but the user
did not push the file. When trying to view the file, Gitea returned a
500 HTTP status code referencing `ErrLFSObjectNotExist`. It appears the
intent was the render this file as plain text, but the conditional was
flipped. I've also added a test to verify that the file is rendered as
plain text.

[2477511] Add spacing to global error message (go-gitea#31826)

Fixes go-gitea#31717.

Include Typescript files in Tailwind config so they can be
pre-processed.

![Screenshot from 2024-08-13
08-44-33](https://github.com/user-attachments/assets/196d7801-e299-4000-8b39-cd9f89917f17)

[5bcab0b] [skip ci] Updated translations via Crowdin

[fe7c941] Scroll images in project issues separately from the remaining issue (go-gitea#31683)

As discussed in go-gitea#31667 & go-gitea#26561, when a card on a Project contains
images, they can overflow the card on its containing column. This aims
to fix this issue via snapping scrollbars.

---
Issue go-gitea#31667 is open to discussion as there should be room for
improvement.

[8883d99] Support issue template assignees (go-gitea#31083)

Resolve go-gitea#13955
4kProgrammer pushed a commit to 4kProgrammer/gitea that referenced this pull request Aug 20, 2024
Squashed commit:

[e1468e2] Fixes for unreachable project issues when transfer repository from organization (go-gitea#31770)
dfhgfdhfghfg
When transferring repositories that have issues linked to a project
board to another organization, the issues remain associated with the
original project board. This causes the columns in the project board to
become bugged, making it difficult to move other issues in or out of the
affected columns. As a solution, I removed the issue relations since the
other organization does not have this project table.

Fix for go-gitea#31538

Co-authored-by: Jason Song <[email protected]>

[c39643f] fghfghf

[38a09ea] render plain text file if the LFS object doesn't exist (go-gitea#31812)gfgdfg

We had an issue where a repo was using LFS to store a file, but the user
did not push the file. When trying to view the file, Gitea returned a
500 HTTP status code referencing `ErrLFSObjectNotExist`. It appears the
intent was the render this file as plain text, but the conditional was
flipped. I've also added a test to verify that the file is rendered as
plain text.

[2477511] Add spacing to global error message (go-gitea#31826)

Fixes go-gitea#31717.

Include Typescript files in Tailwind config so they can be
pre-processed.

![Screenshot from 2024-08-13
08-44-33](https://github.com/user-attachments/assets/196d7801-e299-4000-8b39-cd9f89917f17)

[5bcab0b] [skip ci] Updated translations via Crowdin

[fe7c941] Scroll images in project issues separately from the remaining issue (go-gitea#31683)

As discussed in go-gitea#31667 & go-gitea#26561, when a card on a Project contains
images, they can overflow the card on its containing column. This aims
to fix this issue via snapping scrollbars.

---
Issue go-gitea#31667 is open to discussion as there should be room for
improvement.

[8883d99] Support issue template assignees (go-gitea#31083)

Resolve go-gitea#13955
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/js size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Login page flash warning message broken
4 participants