Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix overflow menu flickering on mobile (#31484) #31488

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

GiteaBot
Copy link
Contributor

Backport #31484 by @brechtvl

The overflow menu button was incorrectly included in the measurement of the width of the items. As a result it could get stuck in a loop alternating between different measurements as the button appears and disappears.


Here's an example of this. I don't know the exact conditions to get it into this state. But just making the window width small on desktop and going back and forth should already show more flickering than there needs to be.

overflow_flicker.mp4

The overflow menu button was incorrectly included in the measurement of
the width of the items. As a result, it could get stuck in a loop
alternating between different measurements as the button appears and
disappears.
@GiteaBot GiteaBot added modifies/js topic/ui Change the appearance of the Gitea UI type/bug labels Jun 25, 2024
@GiteaBot GiteaBot added this to the 1.22.1 milestone Jun 25, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 25, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 25, 2024
@wxiaoguang wxiaoguang enabled auto-merge (squash) June 25, 2024 14:30
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 25, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 25, 2024
@wxiaoguang wxiaoguang merged commit 58b1ee5 into go-gitea:release/v1.22 Jun 25, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/js size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants