Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rearrange Clone Panel #31142

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

BlenderDefender
Copy link
Contributor

This pull request restores the state of the pull request #23231, unfortunately, changing the pull request head is not possible. Created as draft PR until #27931 is merged in.

Rearrange the clone panel to use less horizontal space. The following changes have been made to achieve this:

  • Moved everything into the dropdown menu
  • Moved the HTTPS/SSH Switch to a separate line and made the buttons larger
  • Added a short description what HTTPS- and SSH-Cloning are for
  • Moved the "Clone in VS Code"-Button up and added a divider to separate cloning and downloading
  • Named the dropdown button "Code", added appropriate icon and made the button a primary button to raise more attention.

Before:
grafik

Current look (needs improvements):
grafik

This pull requests aims to fix #23202

This commit restores the state of the pull request from March 2023. The result looks different and still needs to be improved.
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 28, 2024
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 28, 2024
@github-actions github-actions bot added modifies/translation modifies/templates This PR modifies the template files labels May 28, 2024
@lunny lunny added this to the 1.23.0 milestone May 29, 2024
@lunny lunny added the topic/ui Change the appearance of the Gitea UI label May 29, 2024
@silverwind
Copy link
Member

Created as draft PR until #27931 is merged in

Is it really a dependency?

@silverwind
Copy link
Member

silverwind commented Jun 1, 2024

I would strongly prefer if this would use tippy.js for the dropdown menu because fomantic dropdowns have numerous issues and I would like to remove those eventually.

Take a look how the PR review button is implemented, it needs a tiny bit of glue JS to associate the button with the menu content.

@BlenderDefender
Copy link
Contributor Author

Alright, thanks for the feedback 👍
#27931 isn't a really a dependency in the sense that I could only work on this once it's merged in, but this PR almost certainly breaks the other one. If that's not a problem, I'll continue working on this and mark it ready for review as soon as I'm done.

@silverwind
Copy link
Member

silverwind commented Jun 1, 2024

I guess it shouldn't be blocked by that semi-stale PR. It already has accumlated a number of merge conflicts.

Regarding this topic, I'm kind of neutral. On one side I like the 1-click copy behaviour of the current behaviour, but I guess we need to save space on this section which this button brings.

I suggest moving the search field to the right with this change, to the left side of the code button (Edit: I see your screenshot already does that so 👍)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. modifies/templates This PR modifies the template files modifies/translation size/L Denotes a PR that changes 100-499 lines, ignoring generated files. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clone Button Rearrangement
4 participants