Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve mobile review ui #31091

Merged
merged 7 commits into from
May 28, 2024
Merged

Improve mobile review ui #31091

merged 7 commits into from
May 28, 2024

Conversation

silverwind
Copy link
Member

Fixes: #31071

Not perfect but much better than before.

Before: Overflows, sticky not working, filename unreadable:

Screenshot 2024-05-27 at 02 02 40

After:
Screenshot 2024-05-27 at 01 59 06

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 27, 2024
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 27, 2024
@github-actions github-actions bot added the modifies/templates This PR modifies the template files label May 27, 2024
@silverwind
Copy link
Member Author

Should be ready now.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 27, 2024
@silverwind
Copy link
Member Author

Header after latest master merge, still looks fine.

image

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 28, 2024
@lunny
Copy link
Member

lunny commented May 28, 2024

#31071 (comment)

@silverwind
Copy link
Member Author

#31071 (comment)

That should also be fixed here because the resolved placeholder no longer has a fixed height, so it will expand instead of overflow.

@silverwind silverwind mentioned this pull request May 28, 2024
Closed
@silverwind silverwind added the backport/v1.22 This PR should be backported to Gitea 1.22 label May 28, 2024
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 28, 2024
@lunny lunny enabled auto-merge (squash) May 28, 2024 13:13
@lunny lunny merged commit 1e3c4d8 into go-gitea:main May 28, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone May 28, 2024
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request May 28, 2024
@silverwind @GiteaBot
Improve mobile review ui (go-gitea#31091)
0a5c761 
Fixes: go-gitea#31071

Not perfect but much better than before.

Before: Overflows, sticky not working, filename unreadable:

<img width="506" alt="Screenshot 2024-05-27 at 02 02 40"
src="https://github.com/go-gitea/gitea/assets/115237/a06b1edf-dece-4402-98c2-68670fca265f">

After:
<img width="457" alt="Screenshot 2024-05-27 at 01 59 06"
src="https://github.com/go-gitea/gitea/assets/115237/2a282c96-e719-4554-b418-81963ae6269c">
@GiteaBot GiteaBot mentioned this pull request May 28, 2024
Merged
@GiteaBot GiteaBot added backport/done All backports for this PR have been created and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels May 28, 2024
lunny pushed a commit that referenced this pull request May 28, 2024
@GiteaBot @silverwind
Improve mobile review ui (#31091) (#31136)
b615a59 
Backport #31091 by @silverwind

Fixes: #31071

Not perfect but much better than before.

Before: Overflows, sticky not working, filename unreadable:

<img width="506" alt="Screenshot 2024-05-27 at 02 02 40"
src="https://github.com/go-gitea/gitea/assets/115237/a06b1edf-dece-4402-98c2-68670fca265f">

After:
<img width="457" alt="Screenshot 2024-05-27 at 01 59 06"
src="https://github.com/go-gitea/gitea/assets/115237/2a282c96-e719-4554-b418-81963ae6269c">

Co-authored-by: silverwind <[email protected]>
@silverwind silverwind deleted the revui branch May 28, 2024 14:16
zjjhot added a commit to zjjhot/gitea that referenced this pull request May 30, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
c74b94c 
* giteaofficial/main: (30 commits)
  Azure blob storage support (go-gitea#30995)
  Use repo as of renderctx's member rather than a repoPath on metas (go-gitea#29222)
  Ignore FindRecentlyPushedNewBranches err (go-gitea#31164)
  [skip ci] Updated translations via Crowdin
  Fix markup preview (go-gitea#31158)
  Swap word order in Comment and Close (go-gitea#31148)
  Fix push multiple branches error with tests (go-gitea#31151)
  Use vertical layout for multiple code expander buttons (go-gitea#31122)
  Remove duplicate `ProxyPreserveHost` in Apache httpd doc (go-gitea#31143)
  [skip ci] Updated translations via Crowdin
  Add an immutable tarball link to archive download headers for Nix (go-gitea#31139)
  Improve mobile review ui (go-gitea#31091)
  Add topics for repository API (go-gitea#31127)
  Add missed return after `ctx.ServerError` (go-gitea#31130)
  Fix API repository object format missed (