Cleanup resources when create/adopt/generate repository failed #31035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/L
wolfogre
approved these changes
May 27, 2024
GiteaBot
added
lgtm/need 1
yp05327
reviewed
May 27, 2024
services/repository/create.go
Outdated
| @@ -240,13 +241,13 @@ func CreateRepositoryDirectly(ctx context.Context, doer, u *user_model.User, opt | |||
| ObjectFormatName: opts.ObjectFormatName, | |||
| } | |||
|
|
|||
| var rollbackRepo *repo_model.Repository | |||
| needsUpdateStatus := opts.Status == 0 | |||
There was a problem hiding this comment.
Suggested change
| needsUpdateStatus := opts.Status == 0 | |
| needsUpdateStatus := opts.Status == repo_model.RepositoryReady |
There was a problem hiding this comment.
And the previous logic is wrong. It should be opts.Status != repo_model.RepositoryReady.
There was a problem hiding this comment.
I also confused about it.
yp05327
reviewed
May 27, 2024
services/repository/adopt.go
Outdated
| if err := repo_module.CreateRepositoryByExample(ctx, doer, u, repo, true, false); err != nil { | ||
| return err | ||
| } | ||
| if err := repo_module.CreateRepositoryByExample(ctx, doer, u, repo, true, false); err != nil { |
There was a problem hiding this comment.
Will it be rollbacked when it failed?
If yes, then LGTM.
yp05327
approved these changes
May 27, 2024
GiteaBot
added
lgtm/done
|
I will try to have some tests. |
GiteaBot
added
lgtm/need 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #28144