Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust branch button size #3063

Merged
merged 2 commits into from
Dec 2, 2017
Merged

Conversation

silverwind
Copy link
Member

Adjusted the branch button size to more closely match the other buttons beside it. It's still 1px higher than the compare button, but I'm not even sure that that can be solved using semantic classes only.

Before

screen shot 2017-12-02 at 16 13 46

After

screen shot 2017-12-02 at 16 14 01

@codecov-io
Copy link

codecov-io commented Dec 2, 2017

Codecov Report

Merging #3063 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3063      +/-   ##
==========================================
+ Coverage   33.43%   33.45%   +0.01%     
==========================================
  Files         270      270              
  Lines       39553    39553              
==========================================
+ Hits        13226    13232       +6     
+ Misses      24441    24429      -12     
- Partials     1886     1892       +6
Impacted Files Coverage Δ
models/repo.go 37.96% <0%> (-0.19%) ⬇️
modules/indexer/repo.go 63.47% <0%> (+2.6%) ⬆️
models/repo_indexer.go 51.98% <0%> (+2.97%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8cd616e...8a76ace. Read the comment docs.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 2, 2017
@lafriks
Copy link
Member

lafriks commented Dec 2, 2017

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 2, 2017
@ethantkoenig
Copy link
Member

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 2, 2017
@lafriks lafriks added the topic/ui Change the appearance of the Gitea UI label Dec 2, 2017
@lafriks lafriks added this to the 1.4.0 milestone Dec 2, 2017
@lafriks lafriks merged commit f9db60e into go-gitea:master Dec 2, 2017
@silverwind silverwind deleted the compact-branch-button branch December 2, 2017 17:58
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants