Refactor and fix archive link bug #30535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have fully tested related changes:
|
8a0b599
to
5ba660d
Compare
lunny
approved these changes
Apr 17, 2024
Merged
silverwind
reviewed
Apr 17, 2024
silverwind
reviewed
Apr 17, 2024
silverwind
reviewed
Apr 17, 2024
wxiaoguang
commented
Apr 17, 2024
|
BTW, what was the regression? |
I have posted the problem in this comment: #30506 (comment) |
|
Ah I see, I wasn't aware of that button on the release page. |
silverwind
reviewed
Apr 17, 2024
wxiaoguang
commented
Apr 17, 2024
delvh
reviewed
Apr 17, 2024
|
Another problem with callback is that you can not serialize the execution with queryElems('a', async () => {
await fetch();
}); This will and can only run in parallel. It's another reason why I don't like callbacks in general and avoid them wherever possible. Not a problem with these click handlers, but in other code, it may as well become a problem. |
Developers should know what they are writing and doing. For example, there were a lot of "async event listeners" which call "preventDefault" after await in old code, I fixed them one by one, that's why I don't like using async for event listeners, but we are still using them (and more and more) I do not see any real bad case for using it like this for such code. |
2071f28
to
4c12585
Compare
|
Fully rewritten |
4c12585
to
516a280
Compare
silverwind
reviewed
Apr 18, 2024
silverwind
approved these changes
Apr 18, 2024
GiteaBot
added a commit
to GiteaBot/gitea
that referenced
this pull request
Apr 18, 2024
Regression of go-gitea#29920 Fixes: go-gitea#30569 Also this is a rewriting to eliminate the remaining jQuery usages from code. Co-authored-by: Giteabot <[email protected]>
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Apr 19, 2024
* giteaofficial/main: [skip ci] Updated translations via Crowdin Mock queue backoff duration (go-gitea#30553) Improve "Reference in new issue" modal (go-gitea#30547) Add a few root files to lint-spell (go-gitea#30530) Refactor and fix archive link bug (go-gitea#30535) Fixup app.example.ini for task section, which is now queue.task (go-gitea#30555) Some following up changes for routes (go-gitea#30550) Add form field id generation, remove duplicated ids (go-gitea#30546) Fix border-radius on view, blame and code search (go-gitea#30545) Disable enter key for accepting code completion in Monaco (go-gitea#30548)
silverwind
added a commit
that referenced
this pull request
Apr 21, 2024
Backport #30535 by wxiaoguang Regression of #29920 Fixes: #30569 Also this is a rewriting to eliminate the remaining jQuery usages from code. --------- Co-authored-by: wxiaoguang <[email protected]> Co-authored-by: silverwind <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression of #29920
Fixes: #30569
Also this is a rewriting to eliminate the remaining jQuery usages from code.